Skip to content

add sig cloud provider leads to owners #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

add sig cloud provider leads to owners #1212

merged 1 commit into from
Aug 12, 2025
+13 −6

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jul 16, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

as discussed in the 18 June 2025 office hours meeting for sig cloud provider, we agreed to start adding the sig leads to the owners files. this is being done to help with future maintenance.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman July 16, 2025 14:06
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 16, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from olemarkus July 16, 2025 14:06
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Jul 16, 2025

@kmala and @dims, would it be acceptable to clean this up a little more while we are changing it?

if so, what names might we move to emeritus?

@kmala
Copy link
Member

kmala commented Jul 16, 2025

@kmala and @dims, would it be acceptable to clean this up a little more while we are changing it?

if so, what names might we move to emeritus?

i think we can move @nckturner @olemarkus @hakman @kishorj to emeritus as i haven't seen any contribution in the last year unless i missed something.

@olemarkus
Copy link
Member

Can we hold of changing my status for a few weeks? I still keep tabs on this project and I'd like to contribute if I can. I'll report here if that is possible or not.

@kmala
Copy link
Member

kmala commented Jul 16, 2025

Can we hold of changing my status for a few weeks? I still keep tabs on this project and I'd like to contribute if I can. I'll report here if that is possible or not.

Sure, we can review again during the next iteration and keep for now.

@cartermckinnon
Copy link
Contributor

Sounds good to me 👍

@elmiko
Copy link
Contributor Author

elmiko commented Jul 18, 2025

thanks @kmala , i'm happy to queue up the emeritus changes as well.

@olemarkus no rush on our part, we can certainly keep this PR open for a few weeks if that helps.

@olemarkus
Copy link
Member

Thanks. I'd like to keep the role for now and contribute more actively.

@elmiko
add sig cloud provider leads to owners
9abac55 
as discussed in the 18 June 2025 office hours meeting for sig cloud
provider, we agreed to start adding the sig leads to the owners files.
this is being done to help with future maintenance.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Aug 11, 2025

thanks @olemarkus !

i've moved @nckturner , @hakman , and @kishorj to the emeritus approvers, and removed them from the approvers and reviewers. i have left @olemarkus in place, and have added the sig leads to the approvers and reviewers.

@kmala
Copy link
Member

kmala commented Aug 12, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit a97d423 into kubernetes:master Aug 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@kmala kmala

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elmiko @k8s-ci-robot @kmala @olemarkus @cartermckinnon